Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially instancing CFF appears to work, but outlines don't vary #4700

Open
simoncozens opened this issue May 7, 2024 · 2 comments
Open

Comments

@simoncozens
Copy link
Collaborator

% hb-subset --variations=wght=400:900 --unicodes='*' Sans/Variable/OTF/NotoSansCJKjp-VF.otf -o regbold.otf
% shape regbold.otf abc
[gid66=0+563|gid67=1+618|gid68=2+510]

shape

(This is correct at 400 weight, but:)

$ shape regbold.otf abc --variations=wght=900
[gid66=0+606|gid67=1+658|gid68=2+537]

shape

Horizontal metrics have varied correctly, outlines have not.

I don't mind if it doesn't work yet, but it should give a warning or some indication to the user.

@behdad
Copy link
Member

behdad commented May 7, 2024

I thought I implemented this. Will take a look.

@behdad
Copy link
Member

behdad commented May 7, 2024

Oh nevermind. I implemented full instancing, not partial instancing IIRC. It's really complicated but doable...

@qxliu76 can you add a warning or error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants