Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated harfbuzzConfig.cmake doesn't seem correct with PSPSDK #4613

Open
tpimh opened this issue Mar 6, 2024 · 2 comments
Open

Generated harfbuzzConfig.cmake doesn't seem correct with PSPSDK #4613

tpimh opened this issue Mar 6, 2024 · 2 comments

Comments

@tpimh
Copy link

tpimh commented Mar 6, 2024

I am trying to package harfbuzz for PSP: pspdev/psp-packages#115
Currently, the build script is not using meson, and using CMake instead.

The issue that I am facing is that harfbuzzConfig.cmake doesn't seem to be generated correctly.

The issues with this file are:

  1. INTERFACE_INCLUDE_DIRECTORIES is just /harfbuzz (a non-existent path)
  2. INTERFACE_LINK_LIBRARIES has Threads::Threads, but PSPSDK doesn't provide FindThreads.cmake
  3. INTERFACE_LINK_LIBRARIES has correct reference to libfreetype, but not it's dependencies

How can I affect the way how this file is generated?

@khaledhosny
Copy link
Collaborator

The cmake build is “community maintained” as none of HarfBuzz current maintainers knows cmake or uses it, if you know how to fix this issue please submit a PR.

@tpimh
Copy link
Author

tpimh commented Mar 19, 2024

Thanks for your reply! I will try to fix it and submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants