Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tuple_data_t micro-optimization #4472

Open
behdad opened this issue Nov 1, 2023 · 2 comments
Open

tuple_data_t micro-optimization #4472

behdad opened this issue Nov 1, 2023 · 2 comments
Assignees
@qxliu76

Comments

@behdad
Copy link
Member

behdad commented Nov 1, 2023

Are we always sure that indices and x_deltas and y_deltas if available, have the same length? Ie. no allocation failure?
If yes we can use arrayZ in operator *=, operator +=, and possibly other places.
@behdad
Copy link
Member Author

behdad commented Nov 1, 2023

Same in compile_deltas when rounding.

@qxliu76
Copy link
Collaborator

qxliu76 commented Nov 2, 2023

Yes, I think so, I'll work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qxliu76 qxliu76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @qxliu76