Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert dialog showing file operations progress #245

Open
jcgaming-official opened this issue Oct 12, 2023 · 16 comments
Open

Alert dialog showing file operations progress #245

jcgaming-official opened this issue Oct 12, 2023 · 16 comments
Labels
enhancement New feature or request

Comments

@jcgaming-official
Copy link

After I export the video. I tried to play it but it won't play. I have already tried different kinds of video player but nothing works. If the image is exported, the image is fine but the videos are broken. How to fix this?

@hardcore-sushi
Copy link
Owner

Where does the video comes from? Did you record a video from DroidFS or imported an already existing file?

Does it plays well in DroidFS? Can you send the video file?

@jcgaming-official
Copy link
Author

Where does the video comes from? Did you record a video from DroidFS or imported an already existing file?

Does it plays well in DroidFS? Can you send the video file?

The video is a screen record from my local device imported to DroidFS. Yes DroidFS works well to play videos but the exported is broken

@hardcore-sushi
Copy link
Owner

Check that the hash of the file after export is identical to that before import (you can use for example this app).

Can you play it with external video players by selecting "Open with external application" in DroidFS?

@jcgaming-official
Copy link
Author

jcgaming-official commented Oct 12, 2023

Check that the hash of the file after export is identical to that before import (you can use for example this app).

Can you play it with external video players by selecting "Open with external application" in DroidFS?

How can I check the hash before import when I already deleted that file after importing to DroidFs. Video from DroidFs works well to external video player application

@hardcore-sushi
Copy link
Owner

I already deleted that file after importing

Is the exported file the same size as the file in DroidFS?
Can you reproduce the bug with another video? And maybe share it so I can inspect it?

The same code is used for exporting and opening files with external applications. This means that external apps should receive exactly the same bytes as what is written to disk when exporting a file. Can you show your logcat when exporting and opening the video from DroidFS?

@jcgaming-official
Copy link
Author

I already deleted that file after importing

Is the exported file the same size as the file in DroidFS? Can you reproduce the bug with another video? And maybe share it so I can inspect it?

The same code is used for exporting and opening files with external applications. This means that external apps should receive exactly the same bytes as what is written to disk when exporting a file. Can you show your logcat when exporting and opening the video from DroidFS?

It works now. The reason why it broken because when I decrypt and after locating where to save then it will go back do volume and I just exit without knowing there is a toast message saying "Export Successfully" so the exporting is interrupted.

I have a suggestion:
Make a loading activity screen with percentage progress of exporting instead of using toast message. So the user will not exit and know how much time left until successfully export

@hardcore-sushi
Copy link
Owner

Yes that's already a todo feature (TODO.md). At the moment it's shown as a notification.

@hardcore-sushi hardcore-sushi changed the title Videos are Broken/Unplayable after exporting Alert dialog showing file operations progress Oct 14, 2023
@hardcore-sushi hardcore-sushi added the enhancement New feature or request label Oct 14, 2023
@jcgaming-official
Copy link
Author

Sir @hardcore-sushi help. My droidfs is broken. I'm using version 2.1.3. After I export many videos worth 3gb+ storage, my droidfs is now broken. I mean every time I opened the vault, the app kept lagging and kept popping up the "Droidfs is not responding (Close app or Wait), it's keep popping up if I click the wait button. I don't know how to fix it. I have 8+gb ram +5gb ram from additional virtual ram and my android version is 13

@jcgaming-official
Copy link
Author

Sir @hardcore-sushi help. My droidfs is broken. I'm using version 2.1.3. After I export many videos worth 3gb+ storage, my droidfs is now broken. I mean every time I opened the vault, the app kept lagging and kept popping up the "Droidfs is not responding (Close app or Wait), it's keep popping up if I click the wait button. I don't know how to fix it. I have 8+gb ram +5gb ram from additional virtual ram and my android version is 13

It's fixed now. Idk how. But how to fix this?
Screenshot_20231031-122420.jpg

@jcgaming-official
Copy link
Author

Sir @hardcore-sushi help. My droidfs is broken. I'm using version 2.1.3. After I export many videos worth 3gb+ storage, my droidfs is now broken. I mean every time I opened the vault, the app kept lagging and kept popping up the "Droidfs is not responding (Close app or Wait), it's keep popping up if I click the wait button. I don't know how to fix it. I have 8+gb ram +5gb ram from additional virtual ram and my android version is 13

It's happening again.

@hardcore-sushi
Copy link
Owner

Does it keep not responding if you disable thumbnails and folder mapping? Is it a CryFS or a gocryptfs volume? How many files are present in the root directory?

@jcgaming-official
Copy link
Author

Does it keep not responding if you disable thumbnails and folder mapping? Is it a CryFS or a gocryptfs volume? How many files are present in the root directory?

It keeps not responding even I turned off the thumbnail and folder mapping. I used CryFS volume. There is only 2 folders in droidfs root directory and when I go to big folder it starts crashing

@hardcore-sushi
Copy link
Owner

when I go to big folder it starts crashing

OK that's probably the problem. How many files are present in this big folder? Does the original CryFS program work fine when opening this folder on desktop?

If you create a gocryptfs volume and import the big folder in it, does the app crash when opening this folder on this gocryptfs volume?

@jcgaming-official
Copy link
Author

when I go to big folder it starts crashing

OK that's probably the problem. How many files are present in this big folder? Does the original CryFS program work fine when opening this folder on desktop?

If you create a gocryptfs volume and import the big folder in it, does the app crash when opening this folder on this gocryptfs volume?

I haven't tried it on desktop. I'll try to create gocryptfs

@jcgaming-official
Copy link
Author

Hi @hardcore-sushi. Time for feedback. Gocryptfs works really smooth on big volumes. I can even use thumbnail for big files. I don't know why cryfs is slow and not responding. I decided to move the files from cryfs to gocryptfs and I deleted already the cryfs. Thanks for help 🙂 I am waiting for new update

@hardcore-sushi
Copy link
Owner

gocryptfs is faster than CryFS: https://nuetzlich.net/gocryptfs/comparison#performance-on-linux However, DroidFS should not become unresponsive. I'll investigate the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants