New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamcrest should be an osgi bundle #11
Comments
I started looking at this, but there are no plans in the near future. |
@scarytom I will have a look on this and update build.xml using BND plugin. |
@Tibor17 thanks. I'm afraid I don't have a personal need for this, so I've neglected it. |
@Tibor17 thanks. The build.xml is a bit recursive at the moment thanks to the generation of the factory classes. -- another thing I'm working on. Let me know if you need any help. |
@Tibor17 just wondered whether you got anywhere with this. This issue is getting a but crusty and I'm inclined to close as WONT_FIX if nobody is looking at it at all. |
Out of curiosity, does this have to be done within the hamcrest project? Or could it be an extension? |
As, at least in part, it involves tinkering with the META_INF inside the jars, I don't know how easily it would work as an extension. |
Is it enough if we just put the relevant stuff in the META files? |
I think so, but working out the right stuff and baking it into the build scripts isn't trivial, mainly thanks to the magic hamcrest-all bundle... oh how I wish we could ditch that. That said though, I don't want to overplay the issues here -- it isn't that hard. |
I'd like to use Hamcrest in a non-testing application, and our system runs in OSGi so we have to have this. I have only done maven BND plugin config before, but if no one has started working on this I can have a look. |
Thanks @mattbishop Nobody is looking at this at the moment, so feel free to take it on. I'm happy to help with making the necessary changes to the ant build scripts, if you can work out what metadata needs to go where. |
@mattbishop |
My initial view of the pull is that it looks right. I can build it and give Why such an old version of BND? The latest stable release is 2.0.0. On Sat, Apr 6, 2013 at 5:05 PM, Tibor Digana notifications@github.comwrote:
|
@mattbishop |
Include maven-bundle-plugin to generate the default OSGi manifests for the core and library artifacts.
This could potentially be a small change on top of moving to Maven or Gradle; see 79de97a for a take on it using all the defaults. |
This fixes hamcrest#11. The plugin automatically determines Import-Package and Export-Package based on analysis of the classes, and also adds Tool, Bundle-Name, Bundle-Version, Bundle-SymbolicName and others.
Any news about this issue? |
I've seen discussion of this at http://code.google.com/p/hamcrest/issues/detail?id=173 , and the topic has come up in regards to doing the same for Junit (https://github.com/KentBeck/junit/issues/212). Is there any plan for this ?
The text was updated successfully, but these errors were encountered: