Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

为 halo:comment 标签 colorScheme 参数添加 无指定配色 的值 #5890

Closed
HowieHz opened this issue May 10, 2024 · 3 comments
Closed
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@HowieHz
Copy link

HowieHz commented May 10, 2024

你当前使用的版本

No response

描述一下此特性

image
https://docs.halo.run/developer-guide/theme/template-tag/#halocomment
如: normal 或者 auto

image
image

附加信息

No response

@ruibaby
Copy link
Member

ruibaby commented May 13, 2024

添加无指定配色

这个需求是什么呢?当前 auto 无法满足需求吗?或许可以参考 https://github.com/halo-dev/plugin-comment-widget#%E9%85%8D%E8%89%B2%E5%88%87%E6%8D%A2%E6%96%B9%E6%A1%88 强制在主题指定配色方案。

image

此外,这里的文档可能需要更新,<halo:comment /> 标签中的 colorScheme 已经无效,这本身也是以前的设计问题,最好是通过 CSS 变量设置。

@ruibaby ruibaby added the kind/support Categorizes issue or PR as a support question. label May 13, 2024
@HowieHz
Copy link
Author

HowieHz commented May 13, 2024

文档可能需要更新,<halo:comment /> 标签中的 colorScheme 已经无效,这本身也是以前的设计问题,最好是通过 CSS 变量设置。

哦,这个废除了就没啥关系了。
我是在想适配其他的评论系统,通过这个注入要是只能传递 light 和 dark 就会导致设计不统一,其他地方都有 auto light dark,就这中间卡一下没 auto,太突兀了。
@ruibaby

@HowieHz HowieHz closed this as completed May 13, 2024
@ruibaby
Copy link
Member

ruibaby commented May 13, 2024

文档已经提交修改,halo-dev/docs#352

HowieHz added a commit to HowieHz/halo-theme-higan-hz that referenced this issue May 13, 2024
HowieHz added a commit to HowieHz/halo-theme-higan-hz that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Development

No branches or pull requests

2 participants