Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Condition context filter created via "Occurring values" in Properties view is not valid #1104

Closed
JohannaOtt opened this issue Feb 7, 2024 · 4 comments · Fixed by #1184
Assignees
Labels
bug confirmed Issue has been confirmed
Milestone

Comments

@JohannaOtt
Copy link
Contributor

Describe the bug
When creating a condition context on a type using an occurring value from the Properties and editing it, the filter is not valid.

To Reproduce
Steps to reproduce the behavior:

  1. Load the dataset attached to hale studio (using the XPlanGML 5.1 schema from the presets)
    3Aenderung.zip
  2. Determine the occurring values of RP_Landwirtschaft.id
  3. Right click on the value in the Occurring value list and chose "Create condition on parent RP_Landwirtschaft"
  4. Right click on the new condition context and chose "Edit condition context"
  5. The filter is invalid according to the dialogue
  6. When adding quotation marks around id, the filter is valid and still working (filter being "id" = 'GML_517b396a-2685-11ec-962e-1f829c9bb818').

Expected behavior
I would expect the filter created by the functionality in the Occurring values list to be valid

Screenshots
grafik

Additional context
The filter created for other attributes is valid. I assume that the original filter is invalid because of "id" being involved. According to the documentation, it needs the quotation marks but those should then also be used when creating the filter from the Occurring values.

@JohannaOtt JohannaOtt added the bug label Feb 7, 2024
Copy link

github-actions bot commented May 6, 2024

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 6, 2024
@JohannaOtt JohannaOtt added pinned and removed stale labels May 6, 2024
@florianesser florianesser added confirmed Issue has been confirmed and removed pinned labels May 22, 2024
florianesser added a commit that referenced this issue May 22, 2024
When generating a condition context on a parent for a property with a name that
has special meaning in JQL (like `id`), the generated filter does not work as
expected. With this change, the property name is put in quotes so that filters
with special property names work correctly.

#1104
@florianesser florianesser self-assigned this May 22, 2024
florianesser added a commit that referenced this issue May 22, 2024
When generating a condition context on a parent for a property with a name that
has special meaning in JQL (like `id`), the generated filter does not work as
expected. With this change, the property name is put in quotes so that filters
with special property names work correctly.

Closes #1104
@florianesser
Copy link
Member

Can be challenged with this build.

florianesser added a commit that referenced this issue May 22, 2024
When generating a condition context on a parent for a property with a name that
has special meaning in CQL (like `id`), the generated filter does not work as
expected. With this change, the property name is put in quotes so that filters
with special property names work correctly.

Closes #1104
@JohannaOtt
Copy link
Contributor Author

Tested with the workflow described above and the filter is not reported invalid in the dialogue any longer.
@florianesser If I understood the discussion in the related PR correctly, the issue will be closed with the PR and I therefore leave it open now?

@florianesser
Copy link
Member

Thanks for the challenge, @JohannaOtt!

If I understood the discussion in the related PR correctly, the issue will be closed with the PR and I therefore leave it open now?

Yes, exactly. Now that you've challenged it, I will merge the PR which will close the issue.

florianesser added a commit that referenced this issue May 23, 2024
When generating a condition context on a parent for a property with a name that
has special meaning in CQL (like `id`), the generated filter does not work as
expected. With this change, the property name is put in quotes so that filters
with special property names work correctly.

Closes #1104
florianesser added a commit that referenced this issue May 23, 2024
When generating a condition context on a parent for a property with a name that
has special meaning in CQL (like `id`), the generated filter does not work as
expected. With this change, the property name is put in quotes so that filters
with special property names work correctly.

Closes #1104
@florianesser florianesser added this to the 5.2.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Issue has been confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants