-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Condition context filter created via "Occurring values" in Properties view is not valid #1104
Comments
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
When generating a condition context on a parent for a property with a name that has special meaning in JQL (like `id`), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly. #1104
When generating a condition context on a parent for a property with a name that has special meaning in JQL (like `id`), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly. Closes #1104
Can be challenged with this build. |
When generating a condition context on a parent for a property with a name that has special meaning in CQL (like `id`), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly. Closes #1104
Tested with the workflow described above and the filter is not reported invalid in the dialogue any longer. |
Thanks for the challenge, @JohannaOtt!
Yes, exactly. Now that you've challenged it, I will merge the PR which will close the issue. |
When generating a condition context on a parent for a property with a name that has special meaning in CQL (like `id`), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly. Closes #1104
When generating a condition context on a parent for a property with a name that has special meaning in CQL (like `id`), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly. Closes #1104
Describe the bug
When creating a condition context on a type using an occurring value from the Properties and editing it, the filter is not valid.
To Reproduce
Steps to reproduce the behavior:
3Aenderung.zip
RP_Landwirtschaft.id
id
, the filter is valid and still working (filter being"id" = 'GML_517b396a-2685-11ec-962e-1f829c9bb818'
).Expected behavior
I would expect the filter created by the functionality in the Occurring values list to be valid
Screenshots
Additional context
The filter created for other attributes is valid. I assume that the original filter is invalid because of "id" being involved. According to the documentation, it needs the quotation marks but those should then also be used when creating the filter from the Occurring values.
The text was updated successfully, but these errors were encountered: