Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Collapsed InfoClick in iframe #1507

Open
jesade-vbg opened this issue May 13, 2024 · 1 comment · Fixed by #1508
Open

Bug: Collapsed InfoClick in iframe #1507

jesade-vbg opened this issue May 13, 2024 · 1 comment · Fixed by #1508
Assignees
Labels
Projects
Milestone

Comments

@jesade-vbg
Copy link
Contributor

On some occations the InfoClick window gets collapsed when the application is loaded within an iframe.

The window component does not seem to get loaded properly which causes the Rnd component to get the height "dynamic" which is totally wrong as this is not a valid value.

My quickfix is to force "auto" which is the default behaviour of the Rnd component. Otherwise, when Rnd component gets the height value "dynamic" it is set to "0px" which collapses the InfoClick window.

size={{
    width: width,
    height: height === "dynamic" ? "auto" : height,
}}

I know that this does not solve the underlying issue but as this might be urgent or might get urgent for some of us and the fact that some of the UI probably will get a rebuilt soon, I strongly recommend this quick fix.

I'm currently running the fix live.

Let me know your thoughts.

image

@jesade-vbg jesade-vbg added the bug label May 13, 2024
@jesade-vbg jesade-vbg added this to the 3.x milestone May 13, 2024
@jesade-vbg jesade-vbg added this to Approved ideas in Hajk via automation May 13, 2024
@jesade-vbg jesade-vbg self-assigned this May 13, 2024
@jacobwod
Copy link
Member

I recall seeing it on certain occasions, don't think it was limited to embedded instances only. Anyway, since you've got a fix: bring it on. 😃

jesade-vbg added a commit that referenced this issue May 15, 2024
…-iframe

Quick fix for #1507 - make sure Rnd component doesn't get "dynamic" a…
@jesade-vbg jesade-vbg moved this from Approved ideas to Done in Hajk May 15, 2024
@jesade-vbg jesade-vbg modified the milestones: 3.x, 3.13 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Hajk
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants