Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot create or delete map configurations with Hajk admin since the deletion of API v1 #1500

Open
sweco-semara opened this issue Apr 12, 2024 · 0 comments · Fixed by #1501
Open

Cannot create or delete map configurations with Hajk admin since the deletion of API v1 #1500

sweco-semara opened this issue Apr 12, 2024 · 0 comments · Fixed by #1501
Labels
module:admin
Projects
Hajk
Milestone
3.13

Comments

@sweco-semara
Copy link
Contributor

sweco-semara commented Apr 12, 2024 •
edited

Description
Cannot create or delete map configurations with Hajk admin since the deletion of API v1.

To Reproduce
Use admin to create or delete a map config. This fails always.

Expected behavior
Expect latest admin to use API v2, expect maps to be created and deleted as previously possible with API v1.

Suggested Resolution
Could be fixed by:

  1. Adapting admin mapsettings HTTP metods to expected v2 HTTP methods (which are correctly more REST than v1 modifying GET calls)
  2. Adjusting Hajks latest default admin config to expected API v2 mapconfig paths

See PR #1501 for a fix.
sweco-semara added a commit to sweco-se/hajk-fork that referenced this issue Apr 12, 2024
@sweco-semara
Adapt admin mapconfig endpoints to API v2
947beb4 
* Extend API migration documentation with mapconfig steps
* Update Hajk's distributed admin configs
* Resolves hajkmap#1500
@sweco-semara sweco-semara mentioned this issue Apr 12, 2024
Merged
@sweco-semara sweco-semara linked a pull request Apr 12, 2024 that will close this issue
Adapt admin mapconfig endpoints to API v2 #1501
Merged
jacobwod pushed a commit that referenced this issue Apr 15, 2024
@sweco-semara
Adapt admin mapconfig endpoints to API v2 (#1501)
01b348d 
* Extend API migration documentation with mapconfig steps
* Update Hajk's distributed admin configs
* Resolves #1500
@Hallbergs Hallbergs added this to Approved ideas in Hajk via automation Apr 23, 2024
@Hallbergs Hallbergs added this to the 3.13 milestone Apr 23, 2024
@Hallbergs Hallbergs moved this from Approved ideas to Done in Hajk Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:admin
Projects
Hajk
  
Done
Milestone
3.13
Development

Successfully merging a pull request may close this issue.

Adapt admin mapconfig endpoints to API v2 sweco-se/hajk-fork
2 participants
@sweco-semara @Hallbergs