Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QrCode implementation in Print/Anchor #1482

Open
OlofSvahn opened this issue Mar 7, 2024 · 6 comments
Open

QrCode implementation in Print/Anchor #1482

OlofSvahn opened this issue Mar 7, 2024 · 6 comments
Assignees
Projects
Milestone

Comments

@OlofSvahn
Copy link

OlofSvahn commented Mar 7, 2024

So as we all now, qr codes are cool, and therefore we should have them in hajk. Specifically in Print and Anchor (Utskrift and Dela).

I've already tested an implementation using the enableAppStateInHash and it seems to work fine.

Qr codes can be implemented in both print:

image
image

And in Anchor:

image

And we should probably only allow qr code generation if enableAppStateInHash is enabled. Question is, what do we show if enableAppStateInHash is false? Nothing, or maybe inactive buttons? What do you think?

@jesade-vbg jesade-vbg added this to the 3.x milestone Mar 7, 2024
@jesade-vbg
Copy link
Contributor

Really nice. Especially in the Share function!

@Hallbergs
Copy link
Member

Cool!

@jesade-vbg
Copy link
Contributor

Would be great if you could post new screenshots after your changes in Anchor. :)

@OlofSvahnVbg
Copy link
Collaborator

Sure!

So you can now turn qr image on and off like this:
image
image

@OlofSvahnVbg
Copy link
Collaborator

Fuller image:

image

@OlofSvahnVbg
Copy link
Collaborator

And ignore the incorrect tooltip

@OlofSvahnVbg OlofSvahnVbg modified the milestones: 3.x, 3.13 Apr 26, 2024
@OlofSvahnVbg OlofSvahnVbg added this to Approved ideas in Hajk via automation Apr 26, 2024
@OlofSvahnVbg OlofSvahnVbg moved this from Approved ideas to Done in Hajk Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Hajk
  
Done
Development

No branches or pull requests

4 participants