Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stand-alone GeoWebCache WMS and improve WMS admin robustness #1493

Conversation

sweco-semara
Copy link
Contributor

@sweco-semara sweco-semara commented Mar 26, 2024

  • Resolves Stand-alone GeoWebCache WMS-support in Hajk admin and client #1469
  • Add support for new WMS server type "geowebcache-standalone", make REST-call for listing workspaces optional
  • Support GeoWebCache alternative capabilities format, with nested layer structure and single SRS elements (GeoServer and GWC capabilities both conform to the WMS specification, it allows both variants)
  • Add optional support for configuring a default server type, as well as existing option for default URL (backwards compatible, falls back to "geoserver" if not present)
  • Re-name admin WMS option from "GeoWebCache" to tiled (since WMS-C tiled mode has nothing to do with GeoWebCache and it's now a supported server type, making the old admin title for tiled option very confusing)
  • Use constants for WMS versions and server types
  • Avoid non-conformant WMS v1.3.0 GetCapabilities for geowebcache-standalone server type
  • Automatically default to tiled loading for geowebcache-standalone server type
  • Spellcheck admin sv-SE labels for queryable layers ("klick")

More robust WMS admin, guard against GetCapabilties load failures or format errors

  • Console warning if unsupported spatial reference system found in WMS capabilities
  • Fix: Async load could crash WMS admin if clicking too fast on layers/capabilities, not ready for projections update
  • Fix: Do not reference undefined objects in admin after failed GetCapabilities
  • Fix: Handle failed net requests e.g. due to CORS-block, instead of crashing admin
  • Fix: Handle API failures for getting layers config gracefully (e.g. API endpoint version mismatch), instead of crashing admin
  • Fix: Handle HTML responses with 200/OK for failed GetCapabilities (like e.g. Hajk development mode and GeoServer proxy)

* Resolves hajkmap#1469
* Add support for new WMS server type "geowebcache-standalone"
* Add optional support for configuring a default server type, as well as existing option for default URL (backwards compatible, falls back to "geoserver" if not present)
* Re-name admin WMS option from "GeoWebCache" to tiled (since WMS-C tiled mode has nothing to do with GeoWebCache and it's now a supported server type, making the old admin title for tiled option very confusing)
* Use constants for WMS versions and server types
* Avoid non-conformant WMS v1.3.0 GetCapabilities for geowebcache-standalone server type
* Automatically default to tiled loading for geowebcache-standalone server type
* Spellcheck admin sv-SE labels for queryable layers ("klick")

More robust WMS admin, guard against GetCapabilties load failures or format errors
* Console warning if unsupported spatial reference system found in WMS capabilities
* Fix: Async load could crash WMS admin if clicking too fast on layers/capabilities, not ready for projections update
* Fix: Do not reference undefined objects in admin after failed GetCapabilities
* Fix: Handle failed net requests e.g. due to CORS-block, instead of crashing admin
* Fix: Handle API failures for getting layers config gracefully (e.g. API endpoint version mismatch), instead of crashing admin
* Fix: Handle HTML responses with 200/OK for failed GetCapabilities (like e.g. Hajk development mode and GeoServer proxy)
@sweco-semara sweco-semara linked an issue Mar 26, 2024 that may be closed by this pull request
@sweco-semara sweco-semara changed the title Stand-alone GeoWebCache support Add support for stand-alone GeoWebCache WMS and improve WMS admin robustness Mar 26, 2024
@sweco-semara
Copy link
Contributor Author

@Hallbergs Copy/paste bug in CHANGELOG format, my bad - fixed

Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@Hallbergs Hallbergs merged commit 6fe1bf1 into hajkmap:develop Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stand-alone GeoWebCache WMS-support in Hajk admin and client
2 participants