Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch plugin: Save error with arrow object #1450

Open
linusfj opened this issue Jan 10, 2024 · 4 comments
Open

Sketch plugin: Save error with arrow object #1450

linusfj opened this issue Jan 10, 2024 · 4 comments
Assignees
Labels
bug module:client/plugin Functionality that goes into plugins in client
Projects
Milestone

Comments

@linusfj
Copy link
Member

linusfj commented Jan 10, 2024

Describe the bug
An error occurs when attempting to save a workspace in the Sketch plugin after adding an arrow object. The specific error message displayed is: "Error while adding feature: TypeError: i.getZIndex is not a function."

To Reproduce
Steps to reproduce the behavior:

  1. Open the Sketch plugin.
  2. Add an object of the type "Arrow".
  3. Open the Save view.
  4. Attempt to save the workspace.
  5. Note the error message: "Error while adding feature: TypeError: i.getZIndex is not a function."

Expected behavior
The workspace, including the arrow object, should save without any errors.

@linusfj linusfj added bug module:client/plugin Functionality that goes into plugins in client labels Jan 10, 2024
@linusfj linusfj added this to the 3.x milestone Jan 10, 2024
@linusfj linusfj added this to Approved ideas in Hajk via automation Jan 10, 2024
@Hallbergs
Copy link
Member

Looks like its introduced in ef71ff7 @jesade-vbg could you have a look?

@jesade-vbg
Copy link
Contributor

There are actually more bugs related to Arrow. This below happens when you're in edit mode and click on an arrow.

Failed to set arrow style. Error: TypeError: Cannot read properties of undefined (reading 'getStroke')

@Hallbergs
Copy link
Member

Do you want me to take a look at it or will you?

@jesade-vbg
Copy link
Contributor

Looking into it a bit. Noticed another bug. Cant move arrow.

@jesade-vbg jesade-vbg moved this from Approved ideas to Done in Hajk Jan 18, 2024
@jesade-vbg jesade-vbg modified the milestones: 3.x, 3.13 Jan 18, 2024
@jesade-vbg jesade-vbg self-assigned this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module:client/plugin Functionality that goes into plugins in client
Projects
Hajk
  
Done
Development

No branches or pull requests

3 participants