Feature/1438 visible for groups within tool options #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwod
reviewed
Dec 20, 2023
Comment on lines
196
to
+201
| # For development and testing purposes, a user name can be supplied here. | ||
| # Make sure to always disable this in production! | ||
| #AD_OVERRIDE_USER_WITH_VALUE=someUser | ||
| # AD_OVERRIDE_USER_WITH_VALUE=someUser | ||
| # For development and testing purposes, groups can be supplied here. | ||
| # Make sure to always disable this in production! | ||
| # AD_OVERRIDE_USER_GROUPS_WITH_VALUE=someGroup1,someGroup2 |
There was a problem hiding this comment.
I had a quick look at the comment related to these keys and this got me thinking: should we be a bit harder on this and actually not allow these keys at all (or ignore their values in code), if NODE_ENV=production (see line 24). What's your opinion?
There was a problem hiding this comment.
Yes, its a really good idea actually. Prevents .env accidents even more.
There was a problem hiding this comment.
Check added:
9fd17fa
jacobwod
approved these changes
Dec 20, 2023
jesade-vbg
deleted the
feature/1438-visibleForGroups-within-tool-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1438