Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIR plugin - "Exportera" does not use AD-settings #1433

Open
maan002 opened this issue Nov 15, 2023 · 3 comments
Open

KIR plugin - "Exportera" does not use AD-settings #1433

maan002 opened this issue Nov 15, 2023 · 3 comments
Assignees
Labels
Projects
Milestone

Comments

@maan002
Copy link
Contributor

maan002 commented Nov 15, 2023

Describe the bug
All users can see the choices in the "Exportera" tab and press "Skapa Boendeförteckning" even if you configure that users must have a specific AD group to be able to export.

Expected behavior
Either the export tab should be disabled or the contents of the tab should be disabled.
A message should be displayed as to why the tab or content is disabled.

@maan002 maan002 self-assigned this Nov 16, 2023
@maan002 maan002 added the bug label Nov 16, 2023
@maan002 maan002 added this to the 3.13 milestone Nov 16, 2023
@jesade-vbg
Copy link
Contributor

jesade-vbg commented Nov 17, 2023

I dont think this is a bug, it's just unused visibleForGroups settings left in config. Read comment in PR.

@jesade-vbg
Copy link
Contributor

Backend does not remove/filter at that nested level.
image

@jesade-vbg
Copy link
Contributor

My previous comments is related to the fact that I was testing with wrong backend and nodejs-backed lacks this functionality.
This will be adressed in #1438.

The sollution @maan002 presented in PR is working and has been merged.

@jesade-vbg jesade-vbg added this to Approved ideas in Hajk via automation Dec 7, 2023
@jesade-vbg jesade-vbg removed this from Approved ideas in Hajk Dec 7, 2023
@jesade-vbg jesade-vbg added this to Approved ideas in Hajk via automation Dec 7, 2023
@jesade-vbg jesade-vbg moved this from Approved ideas to Done in Hajk Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Hajk
  
Done
Development

No branches or pull requests

2 participants