Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects and Home Pages: Pin Projects Filter to the Top of the Projects List #4593

Open
4 tasks done
Adastros opened this issue May 2, 2023 · 21 comments · Fixed by #4694 · May be fixed by #6747
Open
4 tasks done

Projects and Home Pages: Pin Projects Filter to the Top of the Projects List #4593

Adastros opened this issue May 2, 2023 · 21 comments · Fixed by #4694 · May be fixed by #6747
Assignees
Labels
Complexity: Large P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@Adastros
Copy link
Member

Adastros commented May 2, 2023

Overview

We need to improve the usability of the filters, search and project display so that it is easy for people to navigate the project list.

Details

  • Make the projects filter stay at the top of the content section of the page and scroll independently to allow the user to scroll through all filter options and projects at the same time. So while scrolling through the matching projects on the right, the project filters do not change position".

See how the REI website implements their page when scrolling through the merchandise on the website. The projects filter and list should look and behave similar to it.

The difference between REI and ours is that we have a search bar, that will stay pinned at the top.

Action Items

  • Update the styling for the filter so that the filter is anchored to the top of the parent section element
  • Update the styling for the section element containing the filter and projects list so that the two components scroll independently
    • are pinned to each other when the viewport changes for viewport widths above 767px
    • are centered to the page when the viewport changes for viewport widths above 767px

Resources/Instructions

@Adastros Adastros added role: front end Tasks for front end developers Complexity: Medium P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.5pt Can be done in 3 hours or less Draft Issue is still in the process of being created labels May 2, 2023
@Adastros Adastros added this to New Issue Approval in Project Board via automation May 2, 2023
@Adastros Adastros changed the title Anchor Filter on Projects and Home Page to Top of Projects Component to Allow User to Scroll Filters Projects and Home Page: Anchor Projects Filter to the Top of Projects Component and to the Projects List May 3, 2023
@Adastros Adastros changed the title Projects and Home Page: Anchor Projects Filter to the Top of Projects Component and to the Projects List Projects and Home Pages: Anchor Projects Filter to the Top of Projects Component and to the Projects List May 3, 2023
@Adastros Adastros changed the title Projects and Home Pages: Anchor Projects Filter to the Top of Projects Component and to the Projects List Projects and Home Pages: Anchor Projects Filter Next to and to the Top of the Projects List May 3, 2023
@Adastros Adastros added size: 1pt Can be done in 4-6 hours and removed size: 0.5pt Can be done in 3 hours or less labels May 3, 2023
@Adastros Adastros changed the title Projects and Home Pages: Anchor Projects Filter Next to and to the Top of the Projects List Projects and Home Pages: Pin Projects Filter to the Top of the Projects List May 3, 2023
@Adastros Adastros added Ready for Prioritization and removed Draft Issue is still in the process of being created labels May 3, 2023
@Hritik1503

This comment was marked as outdated.

@Adastros Adastros added the Bug Something isn't working label May 4, 2023
@Adastros

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval to Prioritized backlog in Project Board May 7, 2023
@ExperimentsInHonesty ExperimentsInHonesty added time sensitive Needs to be worked on by a particular timeframe and removed Ready for Prioritization labels May 7, 2023
@agosmou agosmou self-assigned this May 8, 2023
@github-actions

This comment was marked as outdated.

@agosmou

This comment was marked as outdated.

@agosmou agosmou moved this from Prioritized backlog to In progress (actively working) in Project Board May 8, 2023
@roslynwythe roslynwythe added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Feb 25, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval to ERs that are ready to be turned into issues in Project Board Feb 25, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from ERs that are ready to be turned into issues to Prioritized backlog in Project Board Feb 25, 2024
@Anahisv23 Anahisv23 self-assigned this Mar 13, 2024
Copy link

Hi @Anahisv23, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Anahisv23
Copy link
Member

Anahisv23 commented Mar 13, 2024

i. Availability: 11am - 5pm
ii. ETA: Wednesday March 27

@ExperimentsInHonesty
Copy link
Member

@Anahisv23 Please move this to the in progress column

@Anahisv23 Anahisv23 moved this from Prioritized backlog to In progress (actively working) in Project Board Mar 15, 2024
@Anahisv23
Copy link
Member

Hey @ExperimentsInHonesty the issue has been moved to the in progress section on the project board.

@Anahisv23
Copy link
Member

Anahisv23 commented Mar 20, 2024

I had a question regarding issue #4593. I’m trying to understand what the issue is asking. So in the details section of the issue when it says that I need to make the projects filter stay at the top of the content section. If I’m understanding correctly do I need to move the “Applied Filters” div with the class "filter-tag-container" on current-guides.html on line 23 that pops up when a user selects a project filter to the section containing the projects right under the search bar (above the projects list) to make the behavior similar to the REI website? Since in the REI website applied filters are positioned above the product list.

@Anahisv23 Anahisv23 moved this from In progress (actively working) to Questions / In Review in Project Board Mar 20, 2024
@LRenDO
Copy link
Member

LRenDO commented Mar 21, 2024

Hi @Anahisv23! Great job catching the detail that the filter chip position on the example REI link is different from our projects page. I read the issue as focused on adding the fixed behavior the filter sidebar and search bar. @Adastros can you clarify if the selected filter chips should be moved in addition to fixing the filters sidebar and search bar?

@roslynwythe
Copy link
Member

roslynwythe commented Mar 21, 2024

@LRenDO @Anahisv23 I don't believe we want to change the position of the "Applied Filters" chips to match the REI site, but to confirm, I put the question on the agenda for the PM/dev lead meeting of 3/25 and I'll report back. Thank you both for work on this issue!

@ExperimentsInHonesty
Copy link
Member

@Anahisv23 Don't change the location of anything (filters, selected filter items, or search bar). Just figure out how to:

  • keep the filters section on left pinned to the top, and still scrollable in case the list is longer than a user's screen. Don't pin the selected filters separately from the filters section.
  • keep the search bar pinned to the top.

I hope that answers your question. If not, please add this issue back to the questions column, with the ready for dev lead label and additional questions.

@ExperimentsInHonesty ExperimentsInHonesty moved this from Questions / In Review to In progress (actively working) in Project Board Mar 26, 2024
@github-actions github-actions bot added the To Update ! No update has been provided label Mar 29, 2024
Copy link

@Anahisv23

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, March 26, 2024 at 12:06 AM PST.

@Anahisv23
Copy link
Member

Anahisv23 commented Mar 31, 2024

Progress: Currently on vacation so haven’t made much progress on this but will work on this issue next week.
Blockers: None
Availability: April 8 - April 12
ETA: April 8 - April 17

@github-actions github-actions bot removed the To Update ! No update has been provided label Apr 5, 2024
@github-actions github-actions bot added the To Update ! No update has been provided label Apr 12, 2024
Copy link

@Anahisv23

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, April 9, 2024 at 12:06 AM PST.

@Anahisv23
Copy link
Member

Anahisv23 commented Apr 13, 2024

Progress: I'm still working on this. I've managed to update the styling for the filter so that the filter is anchored to the top of the parent section element and added independent scroll to the filter. Still working on pinning the search bar and independent scroll for project lists.
Blockers: None
Availability: 11am - 5pm
ETA: April 24

@github-actions github-actions bot removed the To Update ! No update has been provided label Apr 19, 2024
@Anahisv23
Copy link
Member

Anahisv23 commented Apr 22, 2024

Progress: Still working on this issue. I've managed to allow independent scroll for projects list and filters. Still need to pin filter and search bar to top of the section element.
Blockers: Dabbling with css positioning has been a bit tricky, but I'm learning a lot!
Availability: 11am - 5pm
ETA: April 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Project Board
  
In progress (actively working)
7 participants