Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class file structure and simplifying integration into a framework #150

Open
BrainforgeUK opened this issue Jun 29, 2023 · 1 comment
Open

Comments

@BrainforgeUK
Copy link

I've been looking into integrating H5P into another framework - an alternative to existing Wordpress or Drupal integrations.

To address the issues I've encountered in this can I suggest the changes:

(a) Change all private class functions / properties to protected.
This makes it easier for the framework integrator to extend classes, creating overrides.

(b) Split file h5p.classes.ph into a separate file for each class.
Makes it a lot easier to read and find things.

(c) Add the following line to the top of each file i.e. use namespacing.
namespace h5p_php_library;

Screenshot of the framework class structure I am pursuing.
Long-term this will create maintenance problems with porting changes from github into the framework.
h5p-classes

@SadKul
Copy link

SadKul commented Aug 26, 2023

How can I integrate H5P with CodeIgniter 4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants