Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H5PExport::createExportFile() performance issues #135

Open
catch56 opened this issue Aug 24, 2022 · 0 comments
Open

H5PExport::createExportFile() performance issues #135

catch56 opened this issue Aug 24, 2022 · 0 comments

Comments

@catch56
Copy link

catch56 commented Aug 24, 2022

H5PExport::createExportFile() can cause significant performance issues on network file systems - I've seen it taking 40-60s when saving a column activity using the H5P Drupal module. The same activity takes around 750ms on my local install which is still quite significant.

The main issue is with how dependencies are handled, currently looks like:

  • loops over every dependency
  • copies all of the files from each directory to a folder in /tmp
  • reads those files back out of the /tmp folder into a zip.
  • deletes the files in the tmp directory

Instead, could it:

  • loop over every dependency, build up a list of files in their current locations
  • add those files to the Zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant