Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate PHP and JavaScript code #105

Open
ramonziai opened this issue Oct 12, 2021 · 5 comments
Open

Separate PHP and JavaScript code #105

ramonziai opened this issue Oct 12, 2021 · 5 comments

Comments

@ramonziai
Copy link

First of all, thanks for creating H5P and sharing it with the world!

Now the issue:

The docs (https://h5p.org/creating-your-own-h5p-plugin) state that the intention is to enable the development of H5P integrations in any programming language, and that as much as possible of the core library is JavaScript. This is great, but it's not reflected in the code structure yet. Instead, this repo with the core JS library has 'php' in its name and mixes PHP and JS parts (also subjecting them to the same license, see #16).

Moving the JS parts out of here would enable people to more easily build integrations for non-PHP platforms, and also reduce the impact of viral licensing for those who cannot accommodate such restrictions. A low-barrier first step could be to create a new repo, put the JS code there, and e.g. link it here as a git submodule so it can still be used as before.

What do you think?

@ramonziai
Copy link
Author

Any opinions on this?

@SebastiaanKloos
Copy link

I think this would be awesome.

It looks like they don't use issues in Github that much unfortunately😔

@ramonziai
Copy link
Author

@SebastiaanKloos That's too bad... Thanks for your feedback anyway 😄 Good to know other people are interested in this.

Is there another way of reaching the relevant developers?

@SebastiaanKloos
Copy link

@ramonziai I think they are more active on their public Jira board:
https://h5ptechnology.atlassian.net/projects/HFP/summary

@ramonziai
Copy link
Author

@SebastiaanKloos Thanks a lot, didn't know about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants