Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic html and body styling #50

Open
MiikaL opened this issue Mar 12, 2018 · 3 comments
Open

generic html and body styling #50

MiikaL opened this issue Mar 12, 2018 · 3 comments

Comments

@MiikaL
Copy link

MiikaL commented Mar 12, 2018

Would it be possible to remove the generic html and body styling from the application.scss file? When using the editor as a component in an existing application, this kind of generic styling (particularly the body max-width) can mess up the larger application. Could it just be removed entirely, or then put behind a .h5p-editor class?

@icc
Copy link
Member

icc commented Mar 22, 2018

I see what you mean, I guess there is no problem replacing them with a class.

But I do believe this styling is only used inside the iframe generated by the editor. There shouldn't be any need for loading this outside the iframe.
You could of course drop the iframe, but I think you will run into other issues as well.

@porcospino
Copy link

This is related, so I'll comment here.

editor/styles/css/application.css and editor/styles/scss/application.scss both define max-width: 960px for the html and body elements. This arbitrarily restricts the width of the editor on larger screens.

@icc
Copy link
Member

icc commented May 10, 2019

That is correct, we hope to improve this as we improve the editor experience. Currently, editors like the Branching Scenario overrides this to make use of all the space.
The problem if we just remove this is that all the regular text fields will become way too big due to their default 100% width and this is not desirable in terms of UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants