Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use findSummary if semantics.json does not provide a label #134

Open
otacke opened this issue Jul 7, 2021 · 0 comments
Open

Only use findSummary if semantics.json does not provide a label #134

otacke opened this issue Jul 7, 2021 · 0 comments

Comments

@otacke
Copy link
Contributor

otacke commented Jul 7, 2021

There's an oddity for groups that has been bugging me quite a while, but I never asked whether the current behavior was intended.

The findSummary function is nice, as it can set the group's label based on the contents of the group (text of a text field or metadata title of a library). That function is used unconditionally, however. I assume it was supposed to be a fallback for when the label was not set by semantics.json - but it will even replace a group's label that was set.

This leads to at least a couple of places where a group label would be the content of the first text field that is found in the group, but that doesn't necessarily tell the user what the group is intended for.

Please see Question Set, for instance: The group label is set to "Quiz finished" which tells the user what he/she can set here. Might not be perfect (why not "Summary screen"?), but it's fine. As soon as the user replaces the default message for the "noResultMessage" field which also happens to be "Quiz finished", the group label will change to what he/she entered. A reasonable message for that field could be "You're done!", and the group would now bear the same label - which is weird.

I assume this is a bug and the findSummary function should only be used if the label was not set in semantics, but I thought I'd better ask before fixing this.

Is this a bug or in fact intended behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant