Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to H5P registry #28

Open
2 tasks
ghost opened this issue Oct 12, 2020 · 4 comments
Open
2 tasks

Add missing dependencies to H5P registry #28

ghost opened this issue Oct 12, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 12, 2020

Hey,

Trying to develop / improve existing H5P modules using this CLI tool, but it is missing h5p-editor-show-when in the list of modules.

Getting messages inside drupal like:

"Missing dependency XXX required by YYY to registry"

Following the code here, I am guessing the API for the CLI tool, https://h5p.org/registry.json is not yet updated with the latest available H5P modules yet.

I followed these instructions: https://h5p.org/development-environment to setup with drupal 7 and the H5P cli tool. Installing the true false module with get h5p get h5p-true-false inside h5p's development folder. True false shows up in the hub as installed, but gives the missing dependency error.

As a fallback I tried to use plain git clone on the missing H5P module repo (h5p-editor-show-when) inside the development folder, but this did not help.

Upon adding h5p true false content I receive this error in the console, thrown by h5peditor:

VM2395 h5peditor.js:422 Uncaught TypeError: Cannot read property 'name' of undefined
    at Object.ns.processSemanticsChunk (VM2395 h5peditor.js:422)
    at new MetadataForm (VM2429 h5peditor-metadata.js:293)
    at ns.Form.processSemantics (VM2407 h5peditor-form.js:422)
    at VM2405 h5peditor-library-selector.js:269
    at VM2395 h5peditor.js:224
    at VM2395 h5peditor.js:142
    at HTMLScriptElement.script.onload (VM2395 h5peditor.js:78)

Let me know if any more info is required to debug.

Missing dependencies so far:

  • h5p-editor-show-when required for: h5p-true-false, multiChoice, ...
  • h5p-editor-rangelist required for at least: h5p-summary, ...
@ghost
Copy link
Author

ghost commented Oct 12, 2020

I tried to add the multi choice module as well, same error.

@ghost
Copy link
Author

ghost commented Oct 12, 2020

H5PEditor.RangeList also seems to be missing from the registry

@ghost ghost changed the title Add missing dependency H5PEditor.ShowWhen 1.0 required by H5P.TrueFalse 1.6 to registry Add missing dependencies to H5P registry Oct 12, 2020
@hdagheda
Copy link

Is there any updates on this issue? I'm having same issue while adding course presentation

Uncaught TypeError: Cannot read property 'name' of undefined
    at Object.ns.processSemanticsChunk (h5peditor.js?ver=2020082800:422)
    at new MetadataForm (h5peditor-metadata.js?ver=2020082800:293)
    at ns.Form.processSemantics (h5peditor-form.js?ver=2020082800:422)
    at h5peditor-library-selector.js?ver=2020082800:269
    at h5peditor.js?ver=2020082800:224
    at h5peditor.js?ver=2020082800:142
    at HTMLScriptElement.script.onload (h5peditor.js?ver=2020082800:78)``

@rvantonisse
Copy link

Hey 👋 ,

ℹ️ For your information:
checking in here as the "Ghost 👻 " commenter. I have merged my work related account, rvantonisse-accessibility, with my personal one.

And now that I am here: is this issue still relevant for the h5p-cli? Any updates or comment?

Cheers,
Roel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants