Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker development Windows install instructions #115

Open
mturoci opened this issue Dec 20, 2022 · 11 comments
Open

Update docker development Windows install instructions #115

mturoci opened this issue Dec 20, 2022 · 11 comments
Labels
type/good first issue Good for newcomers

Comments

@mturoci
Copy link
Collaborator

mturoci commented Dec 20, 2022

Update the Windows install instructions in https://github.com/h2oai/wave-apps/tree/main/docker-development, based on the UNIX ones.

@mturoci mturoci added the type/good first issue Good for newcomers label Dec 20, 2022
@InfasMohammed
Copy link

InfasMohammed commented Feb 24, 2023

Here are the updated instructions for installing Docker on Windows:

Check the system requirements: Docker Desktop for Windows requires 64-bit Windows 10 Pro, Enterprise, or Education version 1809 or later, with Hyper-V enabled. You also need at least 4GB of RAM. #

Download Docker Desktop for Windows: Go to the Docker website and download the Docker Desktop for Windows installer.

Run the installer: Double-click the installer to start the installation process. If prompted, allow the installer to make changes to your system.

Configure Docker: After the installation is complete, Docker Desktop launches automatically. You can configure Docker by clicking the Docker icon in the system tray and selecting "Settings". Here, you can adjust settings such as the amount of memory and CPU Docker is allowed to use.

Verify installation: Open a command prompt or PowerShell window and run the command docker version to verify that Docker is installed and running correctly.

Start using Docker: You can start using Docker by running Docker commands in a command prompt or PowerShell window. You can also use a graphical user interface such as Kitematic to manage your Docker containers.

That's it! With these steps, you should now have Docker up and running on your Windows machine.

@mturoci
Copy link
Collaborator Author

mturoci commented Feb 24, 2023

Thanks @InfasMohammed! Can you make a PR with these instructions in the Windows section of this readme?

@mturoci
Copy link
Collaborator Author

mturoci commented Feb 24, 2023

Also please verify, if

git clone https://github.com/h2oai/wave-apps.git
cd wave-apps/docker-development
docker build . -t wave_local_dev
docker run -p 10101:10101 -v $(pwd)/src:/app/src wave_local_dev:latest

work on windows as well and successfully allow you to go to http://localhost:10101 in your browser.

@devarsh10
Copy link

Also please verify, if

git clone https://github.com/h2oai/wave-apps.git
cd wave-apps/docker-development
docker build . -t wave_local_dev
docker run -p 10101:10101 -v $(pwd)/src:/app/src wave_local_dev:latest

work on windows as well and successfully allow you to go to http://localhost:10101 in your browser.

Hey @mturoci, I verified it on Windows and I got the "Hi, Hello World!" message.
Is it expected?

Screenshot:
image

Regards,
Devarsh Shah.

@mturoci
Copy link
Collaborator Author

mturoci commented Oct 6, 2023

Yes @devarsh10, that's right. You can update the README accordingly - the instructions are the same for all OSes.

@devarsh10
Copy link

Okay @mturoci, I just have to add the Docker installation steps right?

@mturoci
Copy link
Collaborator Author

mturoci commented Oct 6, 2023

No. That's covered in https://www.docker.com/. The goal is to make it clear how to run the dockerized app - https://github.com/h2oai/wave-apps/tree/main/docker-development. The wording used may be a bit confusing so we can change installation to set up maybe.

@harshjais369
Copy link

harshjais369 commented Oct 13, 2023

Thanks @InfasMohammed! Can you make a PR with these instructions in the Windows section of this readme?

Could you assign me this issue under hacktoberfest?

@mturoci
Copy link
Collaborator Author

mturoci commented Oct 16, 2023

@harshjais369 you can go ahead. We do not assign issues.

@denzuko
Copy link
Contributor

denzuko commented Nov 20, 2023

One simpler method is to append docker-development/README.md:20 to include / Windows since docker for desktop on win64 systems does have the same CLI tools that MacOS and Linux has, this also includes WSL.

denzuko added a commit to denzuko/wave-apps that referenced this issue Nov 20, 2023
Changes:
  - amends line 20 to make clear that windows also works with the same commands
denzuko added a commit to denzuko/wave-apps that referenced this issue Nov 20, 2023
Changes
  - Implements issue h2oai#115 suggestion for improved verbage.
@denzuko
Copy link
Contributor

denzuko commented Nov 20, 2023

I have both implemented in #123

@mturoci mturoci mentioned this issue Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants