Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic chunk size for uploads #269

Open
pixtron opened this issue Oct 25, 2019 · 2 comments
Open

Dynamic chunk size for uploads #269

pixtron opened this issue Oct 25, 2019 · 2 comments
Assignees
Milestone

Comments

@pixtron
Copy link
Member

pixtron commented Oct 25, 2019

Describe the change

Dynamic chunk size

Current situation

Chunks have a static size.

Should

  • Set a max. chunk size.
  • measure time for each chunk
  • set chunk size for next chunk based on the time the previous chunk needed
  • chunk size should always be a multiply of 512b
  • if request times out (Http Status: 504), upload failing chunk with a decreased chunk size
  • server has a timeout of 5 minutes
@pixtron pixtron added the change label Oct 25, 2019
@pixtron pixtron added this to the v3.3.x milestone Oct 25, 2019
@pixtron pixtron self-assigned this Oct 25, 2019
@raffis raffis modified the milestones: v3.3.x, v4.0.x Dec 3, 2019
@raffis
Copy link
Contributor

raffis commented Dec 5, 2019

Starting with balloon v2.7 the chunksize must always be a multiplication of 64bytes.

@raffis
Copy link
Contributor

raffis commented Dec 6, 2019

Or just do not chunk at all, using the new /api/v3/sessions coming in balloon v3 you may just stream the entire file upwards and/or pause upload and resume it. No need to split it into chunks.

@raffis raffis added the onhold label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants