Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When file is open user should be prompted if he wants to execute certain actions #218

Open
pixtron opened this issue Jun 5, 2019 · 0 comments
Labels
Milestone

Comments

@pixtron
Copy link
Member

pixtron commented Jun 5, 2019

Describe the change

If one of the actions delete, restore version and revert event is triggered, while a file is open the user should be prompted if he want's to execute the action.

Also it should be checked:

  1. if there is any unsaved content
  2. if the file is locked and the lock has to be released

Current situation

The user is alerted that the operations can't be executed when a file is open.

Should

File handlers should return a close handle, so a file can be closed from outside the app that it opened. The corresponding app should handle the necessary unlocking, dirty checking etc.

Also openFile should store the currently opened file, but only for fileHandlers which actually open a file (eg. not preview, not download)

Additional context

This is a follow up issue for #206.

@pixtron pixtron added the change label Jun 5, 2019
@raffis raffis added this to the v3.3.x milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants