Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dynamic API check in future version #137

Open
routerino opened this issue Feb 24, 2024 · 1 comment
Open

Remove Dynamic API check in future version #137

routerino opened this issue Feb 24, 2024 · 1 comment
Labels
chore

Comments

@routerino
Copy link
Contributor

routerino commented Feb 24, 2024 •
edited

The dynamic API check is a necessity due to breaking API changes in the upstream headscale product, but the current fix doubles up on API calls related to devices. This is not a large issue but should be removed in a future version for minor optimisation purposes.
@routerino
Copy link
Contributor Author

Perhaps we can move the check from the start of the API call to only if there was an error within the device calling APIs. This would significantly cut down on redundant calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@routerino