Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Only strings and functions can be passed as "renderer" parameter #5

Open
cyadriane08 opened this issue Sep 15, 2014 · 2 comments

Comments

@cyadriane08
Copy link

Only strings and functions can be passed as "renderer" parameter. i apply this on handsontable 0.11 and i think the issue is because of the cell type "excel".

@francisberesford
Copy link

Hey, I've fixed this by changing jquery.handsontable-excel.js line 1134 from this

Handsontable._TextCell = {
  renderer: Handsontable.TextRenderer,
  editor: Handsontable.TextEditor
};

to this

Handsontable._TextCell = {
  renderer: Handsontable.TextCell.renderer,
  editor: Handsontable.TextCell.editor
};

and on line 1280 this:

editor: Handsontable.TextEditor,

To this

editor: Handsontable.TextCell.editor,

Hope this helps.

@plditallo
Copy link

Thanks FrancisBeresford!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants