Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name of chromecast devices with non-ascii characters has those letters garbled #11

Open
ddaf opened this issue Dec 12, 2014 · 0 comments

Comments

@ddaf
Copy link
Contributor

ddaf commented Dec 12, 2014

If I put non-ascii letters in the name of my chromecast device, the device name returned by chromecast-js will mess up those specific non-ascii letters. I dug deep and found the root to be in mdns-js-packet and have submitted a Pull Request to properly utf8 decode the packets received by mdns-js.

Once/if this PR is accepted we'd need to update the mdns-js2 version we use to integrate the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant