Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users confused when Prout ignores PRs that don't touch configured folders #28

Open
rtyley opened this issue Nov 25, 2015 · 0 comments
Open

Comments

@rtyley
Copy link
Member

rtyley commented Nov 25, 2015

At the moment, Prout only interacts with PRs that touch folders within the project that are next to, or below, a .prout.json config file. This makes sense, because the project might contain many other folders that end up getting deployed to other destinations- that might have other checkpoints, or no checkpoint at all.

Multi-folder support?

This PR didn't touch the dashboard folder (only shared-lib/src/...), and so was correctly ignored by Prout: https://github.com/guardian/ophan/pull/1265/files - but code in shared-lib/src/... does end up deployed to the Ophan Dashboard, so it would be nice to know about it being seen at that checkpoint.

Diagnostics?

It would also be good to have an authenticated endpoint that users can look at to see how Prout regards their project (what is the status of the PRs? which folders is Prout watching?) - any user with push access to a given repo should be able to see that information. Timing attacks in establishing that?! Shouldn't be an issues so long as we are just initially validating the user has push access to the repo, and then checking that it's on Prout's whitelist.

cc @philwills

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant