{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":785377042,"defaultBranch":"master","name":"phosphor-certificate-manager","ownerLogin":"gtmills","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-04-11T19:11:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5455127?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1713451282.0","currentOid":""},"activityList":{"items":[{"before":"0e931ff44051380dbacf1e9ab4acc9deaa07f25b","after":"66cbd8d4faea7dee870182dc4a16bf05c6aaeecb","ref":"refs/heads/show-expire-cert","pushedAt":"2024-04-19T19:23:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gtmills","name":"Gunnar Mills ","path":"/gtmills","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5455127?s=80&v=4"},"commit":{"message":"Don't clear expire date\n\nIf the acf is expired today bmcweb gets back a empty expired date and\nreturns an error to the client. The GUI pukes on this 500 returned and\ncan't log in. 598833\n\nCouple changes:\n1) The GUI is going to handle this error better\n2) Let's show the expired date to the admin user so they can remove the\nACF. This function is a Get Info, it is unexpected it cares if the ACF\nfile is expired.\n\nThis change accomplishes #2 by returning the expired date back back to\nbmcweb which then returns it back to the user.\n\nThis is kind of how 1020-1040 worked\nhttps://github.com/ibm-openbmc/phosphor-certificate-manager/blob/1030/bmc-acf/acf_manager.cpp#L280\n\nIt wasn't until\nhttps://github.com/ibm-openbmc/phosphor-certificate-manager/commit/4532a2afaa2f70c53a8edec9fed5f3cba5fc6d3f\nwe changed how this worked.\n\nThe traces look like\n```\nApr 13 20:38:34 rainxx bmc-acf[297]: ACF is not valid\nApr 13 20:38:34 rainxx bmc-acf[297]: Error:\nApr 13 20:38:34 rainxx bmcweb[2078]: (2024-04-13 20:38:34) [ERROR \"account_service.hpp\":1124] expirationDate format invalid\nApr 13 20:38:34 rainxx bmcweb[2078]: (2024-04-13 20:38:34) [CRITICAL \"error_messages.cpp\":258] Internal Error /usr/src/debug/bmcweb/1.0+git-r0/redfish-core/lib/account_service.hpp(1126:36) `void redfish::getAcfProperties(const std::shared_ptr<bmcweb::AsyncResp>&, const std::tuple<std::vector<unsigned char, std::allocator<unsigned char> >, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >&)`:\n```\n\nTested: Load this on a rainier. Add an ACF that expires 4/12. Move the\nBMC date to 04/13. Could not log in with servie. Could still not see the\nexpire date but could see the acf, I believe this is due to also\nclearing the date in ibm-acf:\nhttps://github.com/ibm-openbmc/ibm-acf/blob/028f49460c04d94c29b67735a63e6f859aab8fac/subprojects/ce-login/celogin/src/CeLoginV2.cpp#L196\n\nSigned-off-by: Gunnar Mills <gmills@us.ibm.com>","shortMessageHtmlLink":"Don't clear expire date"}},{"before":"da22aaee3d329d5e59dbfa9bae47d5722fb2d238","after":"0e931ff44051380dbacf1e9ab4acc9deaa07f25b","ref":"refs/heads/show-expire-cert","pushedAt":"2024-04-19T19:02:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gtmills","name":"Gunnar Mills ","path":"/gtmills","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5455127?s=80&v=4"},"commit":{"message":"Don't clear expire date\n\nIf the acf is expired today bmcweb gets back a empty expired date and\nreturns an error to the client. The GUI pukes on this 500 returned and\ncan't log in. 598833\n\nCouple changes:\n1) The GUI is going to handle this error better\n2) Let's show the expired date to the admin user so they can remove the\nACF. This function is a Get Info, it is unexpected it cares if the ACF\nfile is expired.\n\nThis change accomplishes #2 by returning the expired date back back to\nbmcweb which then returns it back to the user.\n\nThis is kind of how 1020-1040 worked\nhttps://github.com/ibm-openbmc/phosphor-certificate-manager/blob/1030/bmc-acf/acf_manager.cpp#L280\n\nIt wasn't until\nhttps://github.com/ibm-openbmc/phosphor-certificate-manager/commit/4532a2afaa2f70c53a8edec9fed5f3cba5fc6d3f\nwe changed how this worked.\n\nThe traces look like\n```\nApr 13 20:38:34 rainxx bmc-acf[297]: ACF is not valid\nApr 13 20:38:34 rainxx bmc-acf[297]: Error:\nApr 13 20:38:34 rainxx bmcweb[2078]: (2024-04-13 20:38:34) [ERROR \"account_service.hpp\":1124] expirationDate format invalid\nApr 13 20:38:34 rainxx bmcweb[2078]: (2024-04-13 20:38:34) [CRITICAL \"error_messages.cpp\":258] Internal Error /usr/src/debug/bmcweb/1.0+git-r0/redfish-core/lib/account_service.hpp(1126:36) `void redfish::getAcfProperties(const std::shared_ptr<bmcweb::AsyncResp>&, const std::tuple<std::vector<unsigned char, std::allocator<unsigned char> >, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >&)`:\n```\n\nTested: Load this on a rainier. Add an ACF that expires 4/12. Move the\nBMC date to 04/13. Could not log in to the BMC but could view the\nexpired ACF and delete it.\n\nSigned-off-by: Gunnar Mills <gmills@us.ibm.com>","shortMessageHtmlLink":"Don't clear expire date"}},{"before":null,"after":"da22aaee3d329d5e59dbfa9bae47d5722fb2d238","ref":"refs/heads/show-expire-cert","pushedAt":"2024-04-18T14:41:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gtmills","name":"Gunnar Mills ","path":"/gtmills","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5455127?s=80&v=4"},"commit":{"message":"Don't clear expire date\n\nIf the acf is expired today bmcweb gets back a empty expired date and\nreturns an error to the client. The GUI pukes on this 500 returned and\ncan't log in. 598833\n\nCouple changes:\n1) The GUI is going to handle this error better\n2) Let's show the expired date to the admin user so they can remove the\nACF. This function is a Get Info, it is unexpected it cares if the ACF\nfile is expired.\n\nThis change accomplishes #2 by returning the expired date back back to\nbmcweb which then returns it back to the user.\n\nThis is how 1020-1040 worked\nhttps://github.com/ibm-openbmc/phosphor-certificate-manager/blob/1030/bmc-acf/acf_manager.cpp#L280\n\nIt wasn't until\nhttps://github.com/ibm-openbmc/phosphor-certificate-manager/commit/4532a2afaa2f70c53a8edec9fed5f3cba5fc6d3f\nwe changed how this worked.\n\nThe traces look like\n```\nApr 13 20:38:34 rainxx bmc-acf[297]: ACF is not valid\nApr 13 20:38:34 rainxx bmc-acf[297]: Error:\nApr 13 20:38:34 rainxx bmcweb[2078]: (2024-04-13 20:38:34) [ERROR \"account_service.hpp\":1124] expirationDate format invalid\nApr 13 20:38:34 rainxx bmcweb[2078]: (2024-04-13 20:38:34) [CRITICAL \"error_messages.cpp\":258] Internal Error /usr/src/debug/bmcweb/1.0+git-r0/redfish-core/lib/account_service.hpp(1126:36) `void redfish::getAcfProperties(const std::shared_ptr<bmcweb::AsyncResp>&, const std::tuple<std::vector<unsigned char, std::allocator<unsigned char> >, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >&)`:\n```\n\nTested: Load this on a rainier. Add an ACF that expires 4/12. Move the\nBMC date to 04/13. Could not log in to the BMC but could view the\nexpired ACF and delete it.\n\nSigned-off-by: Gunnar Mills <gmills@us.ibm.com>","shortMessageHtmlLink":"Don't clear expire date"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAENXkaYQA","startCursor":null,"endCursor":null}},"title":"Activity · gtmills/phosphor-certificate-manager"}