Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❗ Divider should not come with a margin baked in #121

Open
alexasselin008 opened this issue May 10, 2024 · 1 comment
Open

❗ Divider should not come with a margin baked in #121

alexasselin008 opened this issue May 10, 2024 · 1 comment

Comments

@alexasselin008
Copy link
Member

Description

Taken from slack:

Hey!
Was wondering, would it be possible for the DS divider to not come with a margin baked in?
Margin on reusable components like this breaks encapsulation and indirectly forces us to "calculate" the gap value that needs to be applied to the parent flexbox. Without it, the gap value would just be what's in the Figma

image

@alexasselin008
Copy link
Member Author

i don't think we'll tackle this one has it would introduce a lot of breaking changes, but we should consider this for hopper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant