Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Icons SVG should expose variables to easily change their colors #252

Closed
fraincs opened this issue Apr 26, 2024 · 0 comments · Fixed by #259
Closed

Rich Icons SVG should expose variables to easily change their colors #252

fraincs opened this issue Apr 26, 2024 · 0 comments · Fixed by #259
Assignees

Comments

@fraincs
Copy link
Contributor

fraincs commented Apr 26, 2024

Since Rich Icons SVG don't support props there's currently no way to modify the background color and the shadow color. Adding both variables to the exported SVG would allow anyone to modify these. We should do the same as in the React Icon Component, with the fallback as well.

@franckgaudin franckgaudin self-assigned this May 10, 2024
@franckgaudin franckgaudin linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants