Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine page templates #3871

Closed
8 tasks done
SeamusLeonardHPE opened this issue May 15, 2024 · 3 comments
Closed
8 tasks done

Refine page templates #3871

SeamusLeonardHPE opened this issue May 15, 2024 · 3 comments
Assignees

Comments

@SeamusLeonardHPE
Copy link
Collaborator

SeamusLeonardHPE commented May 15, 2024

Branch Figma file

Ticket size: S/M

Objective

Refine Page Templates i've previously created utilizing refactored or updated components + Seamus's new PageLayout skeletal templates. In addition, let's define naming conventions and nesting elements in correct container.

Success Criteria

  • Easy to digest templates
  • Proper naming conventions/aligned within Figma layers and DS site
  • Easy start up templates + swappable content with updated refactored components

Deliverables

  • Create a branch on new PageLayouts page
  • Review previous templates created with Seamus and agree on the ones we'd like to transfer over
  • Refine and replace any necessary components to bring up to date
  • Refine naming conventions + place elements in correct frames using the naming conventions discussed
  • Share out w/ team
  • Implement feedback
  • Refine where "skeletal" and actual page templates will live
  • Review w/ 2 designers

Seamus's File
https://www.figma.com/design/fupkQ4sOefx3qUVoV6WfJi/Template-Library?node-id=4040-6121

Vicky's previous file
https://www.figma.com/design/4rdBkUlHd5MCVq3hvUOXHd/Page-Layouts?m=auto&node-id=5639%3A166208&t=qnaplY9YsM2qF3Km-1

@vavalos5
Copy link
Collaborator

@SeamusLeonardHPE Take a look at the branch i've created from the work you previously did implementing the work i've previously done. As discussed, i'm proposing we call the "skeletal" work you've done as "PageLayout Breakpoints" and the work i've done "PageLayout Templates".

Please review stickies in file with questions and proposals in file. Thanks!

@vavalos5
Copy link
Collaborator

Sent for a branch review to Seamus.

@vavalos5
Copy link
Collaborator

Seamus and I have merged branch. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants