Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control to switch between dark, light, or system default theme #436

Open
jcfilben opened this issue Nov 2, 2022 · 2 comments
Open

Comments

@jcfilben
Copy link
Collaborator

jcfilben commented Nov 2, 2022

The site now displays in light/dark based on the users browsers preferences. We should have a way for them to toggle the site between light/dark or revert back to the browser preference.

@jcfilben jcfilben added this to Triage in Grommet/Design System Backlog via automation Jan 27, 2023
@ho823
Copy link

ho823 commented Oct 4, 2023

Hi ! I would like use this toggle button : https://design-system.hpe.design/components/button#toggle-buttons for this issue. But I'm not sure to understand, how to use it.
In my mind toggle button seems like this : https://www.google.com/search?sca_esv=570620249&rlz=1C1CHBF_frFR1073FR1073&q=toggle+button&tbm=isch&source=lnms&sa=X&sqi=2&ved=2ahUKEwiM3oqzj9yBAxWjSfEDHUeOA_cQ0pQJegQIChAB&biw=1920&bih=931&dpr=1

So if someone can help me, it would be nice :)

@jcfilben
Copy link
Collaborator Author

jcfilben commented Oct 4, 2023

Hi @ho823 great to hear you are interested in working on this! I think the tricky part of this issue is that we need to support 3 states (light, dark, or system default). So a toggle button might not be the best choice since it only supports 2 states. I realize the language used in the issue title and descriptions may be a bit confusing since it uses the word 'toggle'. Hopefully this clarifies the issue though and I will go back and edit the issue title and description to make this more clear.

@jcfilben jcfilben changed the title Add toggle to switch between dark and light theme Add control to switch between dark, light, or system default theme Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants