Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import on windows is dodgy #3

Open
paulfitz opened this issue Mar 24, 2023 · 1 comment
Open

import on windows is dodgy #3

paulfitz opened this issue Mar 24, 2023 · 1 comment

Comments

@paulfitz
Copy link
Member

paulfitz commented Mar 24, 2023 •
edited

On Windows, importing is a bit wonky in a few ways.

Importing through the in-UI button results in a busy or locked error when unlinking a file (the import has actually succeeded at that point, if you reload, but all very confusing).

image

The File->Open menu doesn't work on windows, in various ways. Maybe best to hide it for now?

Opening a .grist file:
image(1)

Opening a .csv file:
image(2)
@paulfitz paulfitz mentioned this issue Apr 4, 2023
Merged
paulfitz added a commit to gristlabs/grist-core that referenced this issue Apr 4, 2023
@paulfitz
close db after checkAllegedGristDoc (#482)
903c81d 
This closes a file left open during importing, not by the import itself, but by a SQLite integrity check. This was causing imports to fail on Windows (see gristlabs/grist-electron#3)
@paulfitz
Copy link
Member Author

paulfitz commented Apr 5, 2023

Latest version of the app includes some fixes that may help:

  • Closes a file during import in a way that should make Windows happier.
  • Tweaked symlinking (but may still not work for all users, Windows permissions around symlinking are complicated).
  • Restricted File->Open to just .grist files for now since the code for importing is stale.
  • Fixed importing via in-app button (part of the import code wasn't being packaged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulfitz