Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute URLs in Scribble-generated images #157

Open
david-christiansen opened this issue Feb 25, 2016 · 2 comments
Open

Allow absolute URLs in Scribble-generated images #157

david-christiansen opened this issue Feb 25, 2016 · 2 comments

Comments

@david-christiansen
Copy link

I'm working on migrating a site to Frog, including archives of old comments. One thing I'd like to do is to allow old Wordpress comments to be archived, and part of that is pointing at the Gravatar. Unfortunately, Frog is rewriting even absolute URIs for images, breaking the Gravatar links.

It seems that the culprit is likely here. I don't entirely understand the purpose of this line, but perhaps it should only be rewriting the image URI if it does not have "http://" or "https://" as a prefix?

In the meantime, I can hack around this with some clever inline CSS.

@greghendershott
Copy link
Owner

Scribble sources can generate image files. When scribble renders to HTML, it puts these image files in a subdirectory of the .html file. We move them. The code you linked to is adjusting the URLs accordingly.

@greghendershott
Copy link
Owner

That's my recollection of the intended purpose of the code. It's likely that your understanding of it is >= mine, today. :) So if you're motivated to prepare a pull request, I'd be happy to accept it. I think you might be right about distinguishing absolute vs. relative URIs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants