Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS flattening should be based on input numax #225

Open
nielsenmb opened this issue Mar 3, 2020 · 3 comments
Open

TS flattening should be based on input numax #225

nielsenmb opened this issue Mar 3, 2020 · 3 comments

Comments

@nielsenmb
Copy link
Collaborator

In session.clean_lc() the light curve is flattened. This is currently using the default setting which I think is 401 cadences (regardless of long or short cadence).

This might have adverse effects for stars with numax at a comparable frequency (period).

The number of cadences to flatten with should be based on the input numax with a ceiling of some value (401?).

@grd349
Copy link
Owner

grd349 commented Mar 4, 2020

Agreed! We should set the smoothing to be something like t_smooth = x / (numax) where numax is in Hz and x is some number greater than 10. I think that makes sense. If numax is very very uncertain we should raise a warning.

@grd349
Copy link
Owner

grd349 commented Jul 1, 2020

Yes - we came across this agin the other day. @nielsenmb we need a plan on this. Shall we look at it tomorrow in WorkingWithYou?

@nielsenmb
Copy link
Collaborator Author

nielsenmb commented Jul 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants