From 5c673503356d8317b658c97b11bbec62d5af9cac Mon Sep 17 00:00:00 2001
From: Julien Giovaresco <dev@giovaresco.fr>
Date: Thu, 28 Mar 2024 13:14:54 +0100
Subject: [PATCH] fix: remove RequiredArgsConstructor which was overriding
 spring qualifier

Since the introduction of Integration Controller in APIM, we can see the following error

`No qualifying bean of type 'io.gravitee.exchange.api.websocket.command.ExchangeSerDe' available: expected single matching bean but found 2: cockpitExchangeSerDe,integrationExchangeSerDe`

which was due to the extra contructor which applied different bean injection.
---
 .../connectors/ws/WebSocketCockpitConnector.java     | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/gravitee-cockpit-connectors-ws/src/main/java/io/gravitee/cockpit/connectors/ws/WebSocketCockpitConnector.java b/gravitee-cockpit-connectors-ws/src/main/java/io/gravitee/cockpit/connectors/ws/WebSocketCockpitConnector.java
index 5a7a1af..79334d4 100644
--- a/gravitee-cockpit-connectors-ws/src/main/java/io/gravitee/cockpit/connectors/ws/WebSocketCockpitConnector.java
+++ b/gravitee-cockpit-connectors-ws/src/main/java/io/gravitee/cockpit/connectors/ws/WebSocketCockpitConnector.java
@@ -16,6 +16,7 @@
 package io.gravitee.cockpit.connectors.ws;
 
 import io.gravitee.cockpit.api.CockpitConnector;
+import io.gravitee.cockpit.api.command.websocket.CockpitExchangeSerDe;
 import io.gravitee.cockpit.connectors.ws.command.CockpitConnectorCommandContext;
 import io.gravitee.common.service.AbstractService;
 import io.gravitee.exchange.api.command.Command;
@@ -45,8 +46,9 @@
  * @author Jeoffrey HAEYAERT (jeoffrey.haeyaert at graviteesource.com)
  * @author GraviteeSource Team
  */
+// This class is instanciated as a Spring Component by Gravitee Node
+@SuppressWarnings("SpringJavaInjectionPointsAutowiringInspection")
 @Slf4j
-@RequiredArgsConstructor
 public class WebSocketCockpitConnector extends AbstractService<CockpitConnector> implements CockpitConnector {
 
     public static final ProtocolVersion PROTOCOL_VERSION = ProtocolVersion.V1;
@@ -55,20 +57,20 @@ public class WebSocketCockpitConnector extends AbstractService<CockpitConnector>
     private Vertx vertx;
 
     @Autowired
-    private final ExchangeConnectorManager exchangeConnectorManager;
+    private ExchangeConnectorManager exchangeConnectorManager;
 
     @Autowired
     @Lazy
     @Qualifier("cockpitConnectorCommandHandlersFactory")
-    private final ConnectorCommandHandlersFactory cockpitConnectorCommandHandlersFactory;
+    private ConnectorCommandHandlersFactory cockpitConnectorCommandHandlersFactory;
 
     @Autowired
     @Qualifier("cockpitWebsocketConnectorClientFactory")
-    private final WebSocketConnectorClientFactory cockpitWebsocketConnectorClientFactory;
+    private WebSocketConnectorClientFactory cockpitWebsocketConnectorClientFactory;
 
     @Autowired
     @Qualifier("cockpitExchangeSerDe")
-    private final ExchangeSerDe cockpitExchangeSerDe;
+    private ExchangeSerDe cockpitExchangeSerDe;
 
     @Value("${cockpit.enabled:false}")
     private boolean enabled;