Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SSG doesn't look like it properly handles ties? #944

Closed
ebridge2 opened this issue May 5, 2022 · 1 comment
Closed

[BUG] SSG doesn't look like it properly handles ties? #944

ebridge2 opened this issue May 5, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ebridge2
Copy link
Collaborator

ebridge2 commented May 5, 2022

Expected Behavior

if there is a tie in the test statistic, the tie should be randomly broken

Actual behavior

it does not appear that potential ties are randomly broken

https://github.com/microsoft/graspologic/blob/dev/graspologic/subgraph/sg.py

@jovo

@ebridge2 ebridge2 added the bug Something isn't working label May 5, 2022
@bdpedigo
Copy link
Collaborator

closing in favor of #977 which looks to have more detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants