Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema parser doesn't handle "&" when specifying multiple interfaces #70

Open
wravery opened this issue Aug 25, 2018 · 4 comments
Open

Comments

@wravery
Copy link

wravery commented Aug 25, 2018

If I'm reading the spec right, type definitions which implement multiple interfaces should have a & separator between the interface names and optionally before the first interface name for a single interface. The parser rule for implements_interfaces_opt in parser.ypp only expects whitespace.

@swolchok
Copy link
Contributor

swolchok commented Sep 6, 2018

Makes sense, the schema definition language support was based off a proposal and hasn't been updated to reflect the June 2018 edition of the spec. I need to take a look at how much work that's going to be...

@felipecrv
Copy link

@swolchok how experimental is the schema support in parseFileWithExperimentalSchemaSupport()?

@swolchok
Copy link
Contributor

It's not compliant with the June 2018 spec. It reflects the RFC as it was on the date when it was committed. #45 added it based on graphql/graphql-spec#90 as it was on the day it was committed. I have an unfinished stack to port the changes made since then to libgraphqlparser; the major snag is that the object model for the libgraphqlparser AST (base classes + inheritance) doesn't really accommodate matching the graphql-js AST for schema things exactly because I would have to do weird things with multiple inheritance.

I'm a bit fuzzy on how widely used libgraphqlparser is. If there are a lot of people waiting for these updates, that might motivate me to dust off the stack sooner rather than later. :)

@felipecrv
Copy link

I'm a bit fuzzy on how widely used libgraphqlparser is. If there are a lot of people waiting for these updates, that might motivate me to dust off the stack sooner rather than later. :)

I'm writing a prototype thing that might be put into production... or not. I think the October 2016 spec (http://facebook.github.io/graphql/October2016/) is good enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants