Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaPrinter not outputting "extend schema" for extensionDefinitions #3428

Closed
RoKKim opened this issue Jan 31, 2024 · 2 comments
Closed

SchemaPrinter not outputting "extend schema" for extensionDefinitions #3428

RoKKim opened this issue Jan 31, 2024 · 2 comments

Comments

@RoKKim
Copy link

RoKKim commented Jan 31, 2024

Describe the bug
When calling graphql.schema.idl.SchemaPrinter#schemaPrinter with a schema that has graphql.schema.GraphQLSchema#extensionDefinitions defined, I would expect it to print out the "extend schema" string. I would expect the graphql.schema.idl.SchemaPrinter#schemaPrinter to:

  1. Check if options.isUseAstDefinitions() returns true.
  2. Print "extend schema" for each out.print(AstPrinter.printAst(extension));.

Alternatively, is there another method to enable printing of the extensions?

@dondonz dondonz added the keep-open Tells Stale Bot to keep PRs and issues open label Feb 11, 2024
@dondonz
Copy link
Member

dondonz commented Feb 24, 2024

Hello, thanks for reporting, I think this was forgotten about. It should be added to the Schema Printer

@dondonz
Copy link
Member

dondonz commented Jun 4, 2024

The fix for this issue was included in the v22.1 release, thanks for reporting the issue

@dondonz dondonz closed this as completed Jun 4, 2024
@dondonz dondonz removed the keep-open Tells Stale Bot to keep PRs and issues open label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@dondonz @RoKKim and others