Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Collector as possible optimization #2209

Closed
andimarek opened this issue Feb 17, 2021 · 5 comments
Closed

Field Collector as possible optimization #2209

andimarek opened this issue Feb 17, 2021 · 5 comments
Labels

Comments

@andimarek
Copy link
Member

Looking at some Microbenchmarks it seems that FieldCollector could be optimized. Especially ConditionalNodes which is called by FieldCollector is worth looking at.

@andimarek
Copy link
Member Author

One idea: is to not use MergedField at all inside the collector.

@dfa1
Copy link
Contributor

dfa1 commented Feb 18, 2021

@andimarek please have a look #2216

@bbakerman bbakerman linked a pull request Feb 26, 2021 that will close this issue
Copy link

Hello, this issue has been inactive for 60 days, so we're marking it as stale. If you would like to continue this discussion, please comment within the next 30 days or we'll close the issue.

@github-actions github-actions bot added the Stale label Dec 28, 2023
@bhabegger
Copy link

@dfa1 @andimarek @bbakerman Anything to be done here ?

@dondonz
Copy link
Member

dondonz commented Jun 4, 2024

Hello I'm closing this ticket as it's quite an old one, there is nothing to do right now.

@dondonz dondonz closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@bhabegger @andimarek @dfa1 @dondonz and others