Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julian and other non-Gregorian calendars in date inputs #273

Open
arkhipov opened this issue Aug 25, 2023 · 1 comment
Open

Support Julian and other non-Gregorian calendars in date inputs #273

arkhipov opened this issue Aug 25, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@arkhipov
Copy link
Contributor

arkhipov commented Aug 25, 2023

Hello! First, thanks a lot for a great application. I had been looking forward to something like that for a long time since the Gramps desktop application had appeared.

In the Russian Empire (and probably in other countries with the same religion), the Orthodox Church used the Julian calendar until about the year of 1920. The desktop application allows to choose a calendar in every date input. At the moment, Gramps.JS shows the correct calendar name when you export data from the desktop application, but it does not allow me to enter new dates and edit already entered dates using that calendar.

It would be great to support that in the web application as well. If you give me some hints and suggestions, I can implement this feature on my own and send you a patch.

@DavidMStraub DavidMStraub added the enhancement New feature or request label Aug 25, 2023
@DavidMStraub
Copy link
Member

Yes, that makes sense! You only have to edit the file GrampsjsFormSelectDate.js. You can look at how the other dropdowns are handled to get an idea how it works. Let me know if you have questions.

We should then disable the date pickers if a calendar other the Gregorian is selected, since the browser built in date pickers don't support other calendars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants