-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darkmode for Web Interface #145
Comments
I agree this would be something that some users might find useful. Personally, I will not work on it since it's a huge amount of work for a feature I will not use. If someone wants to tackle this, please self-assign and I can provide guidance if needed. |
I might be interested in looking into this. @DavidMStraub Are there any guidelines regarding dark mode design tokens, or would this still need to be sorted? |
Hi, that would be great! There are no guidelines yet. However, over the next month, I expect we will slowly start migrating the components from the legacy material components v0.25 to the new material web v1.0, which has built-in support for themes as far as I can see. Perhaps we can already start using those conventions? Does that help? At the moment, the main colors are set here using the CSS variables of the old material components: However, there are still many components that have hard-coded colors (e.g. shades of gray), that will have to be adapted. Some suggestions for implementing the dark mode switch:
|
Hi @DavidMStraub - I've got some time this week and would like to dig into this a bit. I've hit my first glitch though, after setting up a dev environment, I can't seem to register a test user - every combination I've tried just returns a |
Hi, how did you set up the dev environment? If you use this https://www.grampsweb.org/dev-frontend/setup/, user accounts should already be there, see https://github.com/gramps-project/gramps-web/blob/main/dev/Dockerfile.api#L19-L24 By the way, since I last commented here, I have started adding Material Web components ( https://github.com/gramps-project/gramps-web/blob/main/src/SharedStyles.js#L20-L70 |
(Confusingly, in the new Material Web, components and CSS variables start with |
It would be nice, having the option for toggeling light / dark mode.
Possible location would be in the settings menu or next to the search / profile icon top right.
The text was updated successfully, but these errors were encountered: