Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest tag is invalid #59

Open
dvzrv opened this issue Jun 26, 2022 · 5 comments
Open

Latest tag is invalid #59

dvzrv opened this issue Jun 26, 2022 · 5 comments

Comments

@dvzrv
Copy link

dvzrv commented Jun 26, 2022

Hi! I package this project for Arch Linux.

Your latest tag is invalid. Please release one that follows semver and that sorts newer than 3.21, as I will otherwise not package it.

@dfober
Copy link
Member

dfober commented Jun 26, 2022

I don't understand why v.3.22 don't sort newer than v.3.21.

@dvzrv
Copy link
Author

dvzrv commented Jun 26, 2022

I don't understand why v.3.22 don't sort newer than v.3.21.

Well, apart from v.3.21 not existing in this repository, both would not be valid according to semver.

Are you sure that you want to replace your major version with v? To me it rather looks like a typo while creating the tag. :)

@dfober
Copy link
Member

dfober commented Jun 26, 2022

ok, I'll try to tag according to semver in the future. If I create a new tag 3.2.2, would it be ok for you? Do you need a new release with this tag?

@dvzrv
Copy link
Author

dvzrv commented Jun 26, 2022

If I create a new tag 3.2.2, would it be ok for you?

3.2.2 would also sort lower than 3.21. You probably meant 3.22?
FWIW, it is completely fine to keep the v prefix. Consistency is important.

Do you need a new release with this tag?

Yes, please tag ea73d11 with v3.22. Thanks! ❤️

@dfober
Copy link
Member

dfober commented Jun 27, 2022

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants