Project 2 Feedback

[Avizacherman]

Graig,

Really nice job on your project. It looks very good on the front end and your back end is pretty well organized. I like that you implemented the currency conversion functionality and that I can create my own administrator account.

Your server side code is very clean and well written. One thing I will say is try not to put things directly into your ApplicationController, as you did with some of the currency stuff. Though it is functional and does make it accessible to all your controllers (and is therefore better than repeating yourself) and even better practice would be to create helper files for it and include the modules from those helpers. Let me know if that makes sense. Rails convention is all about separating concerns to an almost ad nauseum degree.

Great, great job! 2.5 out of 3.