Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some struct fields are not go-idiomatic #21

Open
philcluff opened this issue May 28, 2015 · 1 comment
Open

Some struct fields are not go-idiomatic #21

philcluff opened this issue May 28, 2015 · 1 comment

Comments

@philcluff
Copy link

Hi there,

Some field names in the structs in structure.go are not go-idiomatic, for example:

ProgramId (ProgramID)
GroupId (GroupID)
SeqId (SeqID)
Iframe (IFrame)

Happy to provide a PR if you want to go in this direction.

Cheers,

@grafov
Copy link
Owner

grafov commented May 31, 2015

Well, historically development of the project was not strongly follow go-idioms and make API follow rules of naming is good idea. But the library already used in some proprietary software and these changes will made it incompatible. Anyway I plan to cleanup code in this direction before 1.0 but not in near release. Now I interested in bugfixes and supporting of latest M3U8 specs.

I left this issue open for discussion for the library users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants