Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make target port for fault injection for pods required #245

Open
Tracked by #251
pablochacin opened this issue Jun 29, 2023 · 0 comments
Open
Tracked by #251

Make target port for fault injection for pods required #245

pablochacin opened this issue Jun 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@pablochacin
Copy link
Collaborator

Presently, if no port is specified when injecting a fault to a Pod, a default port is used.
This behavior may introduce errors such as targeting a non-intended port.

Also, as mentioned in #161 the agent should expect this parameter as mandatory, and this behavior should be consistent between the disruptor API and the agent.

Note: this breaking change would break the HTTP fault injection example

@pablochacin pablochacin added the enhancement New feature or request label Jun 29, 2023
@pablochacin pablochacin changed the title Make target port for fault injection for pods mandatory Make target port for fault injection for pods required Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant