Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Profiler from runtime environment #203

Open
pablochacin opened this issue Jun 14, 2023 · 0 comments
Open

Remove Profiler from runtime environment #203

pablochacin opened this issue Jun 14, 2023 · 0 comments
Labels
enhancement New feature or request internal improvement improves code quality or organization

Comments

@pablochacin
Copy link
Collaborator

Since #172 an abstraction for the runtime environment was introduced with the goal of facilitating the testing of the agent.
Among the abstractions introduced in the runtime environment, there was the Profiler, which controls the profiling of the agent execution.

The profiler is only used in the context of the profiling options added to the root command and is of no interest in other contexts. However, it still introduces some additional complexity to the runtime environment (for example, the need of creating a fake profiler for testing, even when it is not used)

Therefore, it would be beneficial to remove the Profiler from the runtime environment and make it accessible from the runtime package.

The main drawback of this change would be that it prevents creating a mock for the profiler in case we want to test how the agent starts/stops it.

@pablochacin pablochacin added enhancement New feature or request internal improvement improves code quality or organization labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal improvement improves code quality or organization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant