Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace root span incorrectly identified due to instrumentation #3634

Open
ie-pham opened this issue May 1, 2024 · 0 comments
Open

trace root span incorrectly identified due to instrumentation #3634

ie-pham opened this issue May 1, 2024 · 0 comments
Assignees
Labels
keepalive Label to exempt Issues / PRs from stale workflow type/bug Something isn't working

Comments

@ie-pham
Copy link
Collaborator

ie-pham commented May 1, 2024

Consider the following trace:

[
    Span{
        traceId: "39343434",
        spanId: "aaa"
        parentSpanId: "",
        links: [
            link{
                traceId: "39343434"
                spanId: "bbb"
                atributes: {
                    "opentracing.ref_type": "child_of"
                }
            }
        ]
    },
    Span{
        traceId: "39343434",
        spanId: "bbb"
        parentSpanId: "",
        links: []
    },
    Span{
        traceId: "39343434",
       spanId: "ccc"
        parentSpanId: "",
        links: [
            link{
                traceId: "39343434"
                spanId: "aaa"
                atributes: {
                    "opentracing.ref_type": "child_of"
                }
            }
        ]
    }
 
 ]

Currently, Tempo labels any spans with an empty parentSpanId field as the root span. In the above situation, Tempo would label whichever of the three spans is ingested last. Tempo should also check whether there is a link with attribute child of before labeling the span as the root span. The correct root span is bbb as it has no child of links.

@ie-pham ie-pham self-assigned this May 1, 2024
@joe-elliott joe-elliott added type/bug Something isn't working keepalive Label to exempt Issues / PRs from stale workflow labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Label to exempt Issues / PRs from stale workflow type/bug Something isn't working
Projects
Status: Next
Development

No branches or pull requests

2 participants