Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log level configurable #587

Open
pavolloffay opened this issue Sep 4, 2023 · 4 comments
Open

Make log level configurable #587

pavolloffay opened this issue Sep 4, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@pavolloffay
Copy link
Collaborator

The log level is set as CMD argument. It would be helpful to expose it in the CRD e.g. in the observability spec

type ObservabilitySpec struct {

@pavolloffay pavolloffay added the enhancement New feature or request label Sep 4, 2023
@andreasgerstmayr
Copy link
Collaborator

Related PR to make it easier to change the log level for ad-hoc debug sessions using unmanaged mode: #550

@yuriolisa
Copy link
Contributor

Guys, can I get this one?

@andreasgerstmayr
Copy link
Collaborator

andreasgerstmayr commented Feb 6, 2024

Guys, can I get this one?

We have multiple components (operator, tempo, tempoQuery, tempoGateway, tempoGatewayOpa) - should we have one setting to change the log level for all components? One setting per component?

Currently you can switch the Tempo CR to Unmanaged mode, and edit the -log.level CLI argument of the deployment/statefulset you want to debug. imho this is an efficient way to debug the instance (e.g. you can also change the command of the pod, etc.), what do you think? Is an additional field in the CR required?

@yuriolisa
Copy link
Contributor

@andreasgerstmayr, I believe we could keep both, the CLI parameters and add a new logLevel to the ObservabilitySpec which will work as a global loglevel as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants